dmind-gmbh / extension-cookieman

A GDPR tracking consent popup for the content management system TYPO3. It asks for approval to include tracking objects (cookies, images or any HTML) and includes the objects when consented.
https://extensions.typo3.org/extension/cookieman
GNU General Public License v2.0
34 stars 17 forks source link

TYPO3 12 compatibility #304

Open svewap opened 1 year ago

svewap commented 1 year ago

Here is my version for T3 12: https://github.com/svewap/extension-cookieman/tree/12-svewap I can make a pull request if you want.

jonaseberle commented 1 year ago

Thanks Sven! Yes, please open a PR :) I have branched off 11lts so we can work on v12 together.

There is https://github.com/dmind-gmbh/extension-cookieman/issues/271 which needs to be solved.

I am planning to work next week on it.

weisgerberm commented 1 year ago

Hi, any Updates for v12 support? Thank you

zenoussi commented 1 year ago

Hi, any Updates for v12 support? Thank you

Same question. Thanks

svewap commented 1 year ago

I opened a PR

ingeniumdesign commented 1 year ago

new Infos?

jonaseberle commented 1 year ago

Sorry, not much yet.

You can use https://github.com/dmind-gmbh/extension-cookieman/pull/311 which works very well.

What's holding me back is that I would like to have a good solution for https://github.com/dmind-gmbh/extension-cookieman/issues/271 because v12 (or rather typo3/cms-composer-installers:^5) changes the paths of public assets. Most users will not hit that problem (of including files in inject()) and there are ways to work around it.

msollmann commented 10 months ago

Overriding of labels via _LOCAL_LANG isn't working anymore. Do we have to use locallangXMLOverride instead?

jonaseberle commented 10 months ago

@msollmann You mean in the T3 v12 branch?

msollmann commented 10 months ago

In https://github.com/dmind-gmbh/extension-cookieman/pull/311.

In addition I can only override my own labels (e.g. "group.externalServices"), not existing labels (e.g. "group.marketing") via locallangXMLOverride.

ingeniumdesign commented 8 months ago

new Infos?

Finulin commented 8 months ago

release for TYPO3 v12 would be nice

jonaseberle commented 8 months ago

Yes, I agree, but I have not found the time. It would really help if you could test #311 and leave feedback there.

If someone would like to dive into the docs and adjust the examples where needed, that would help as well.

jonaseberle commented 7 months ago

@msollmann your translation problem is https://forge.typo3.org/issues/100759

ingeniumdesign commented 6 months ago

Maybe as a christmas present? :)

jonaseberle commented 6 months ago

@ingeniumdesign yes, thank you, please go ahead and test https://github.com/dmind-gmbh/extension-cookieman/pull/323 ;) composer req dmind/cookieman:dev-dev/12lts.

ingeniumdesign commented 5 months ago

The installation worked fine, the output works fine, now I'll test the settings a bit more

jonaseberle commented 5 months ago

The _LOCAL_LANG TypoScript issue should be solved in TYPO3 v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023.

ingeniumdesign commented 1 week ago

yes, the _LOCAL_LANG TypoScript issue dont work. New Infos?

jonaseberle commented 1 week ago

@ingeniumdesign Are you adding the extensionName in translations like this? {f:translate(key: 'heading', extensionName: 'cookieman')}