dmirandaa / moodle-auth_saml2sso

Moodle plugin for authentication using a SimpleSAMLphp Service Provider
https://moodle.org/plugins/auth_saml2sso
0 stars 6 forks source link

missing a trailing slash for the "SAML2 Service Provider (SP)" setting #1

Closed iv-enovation closed 7 years ago

iv-enovation commented 7 years ago

when a user enters a config value without a trailing slash, like "/var/www/ticket/simplesaml", an incorrect path to a lib is calculated, like "/var/www/ticket/simplesamllib/_autoload.php"

there is no clear requirement to always include the trailing slash and the configuration is accepted by Moodle without it

the easiest way to fix this problem would be concatenating '/lib/_autoload.php', with the leading slash, as even if a user enters the value with the slash it'll result in a path like /var/www/ticket/simplesaml//lib/_autoload.php which is going to be found on a disk