dmirandaa / moodle-auth_saml2sso

Moodle plugin for authentication using a SimpleSAMLphp Service Provider
https://moodle.org/plugins/auth_saml2sso
0 stars 6 forks source link

SAML logout is called for non-saml users #14

Closed iv-enovation closed 6 years ago

iv-enovation commented 6 years ago

in auth.php in logoutpage_hook() the part of invoking $auth->getLogoutURL() depends only on the "single_signoff" plugin configuration. Every manual user is also calling this function and then they are brought to an error SimnpleSAMLphp page. This is especially a problem for admin users that very often are left manual

the suggested solution is in the attached patch. There can be a better way of defining self::AUTHTYPE

auth_saml2sso.logouthook.patch.txt