added code so its set as button instead of direct login

[neeesn]

Sets a button for saml2sso as IDSP so theres option still to use moodle login

[neeesn]

Setting code into dual login - dual login = yes - Button is showed on login - Dual login = no - user is directly redirected to saml login

[neeesn]

Option to set url as button in the settings.

[neeesn]

Damit -didnt mean to close it

[dmirandaa]

Hi Henrik, I think the approach to add a button to allow user to select IdP auth is opposite to the purpose of this plugin. The primary condition is to always redirect every user to IdP authentication, unless they know how to login with a local Moodle account, maybe only admin could do that. To login with a local account you just need pass saml=off parameter to /login/index.php?saml=off url.

[mfprimo]

Hi Daniel, I totally agree with you that the primary purpose of this plugin should be to redirect every user to IdP authentication.

But we have more than 50 Moodle instances and in a few of them we share both SSO and local (or LDAP or DB) user accounts. From our experience, in these cases it is impractical to explain to the users how to login skipping SSO using a query parameter. In addition, I think that the "dual login" term is a little misleading.

Thus my above proposal:

• regardless dual login, saml=off always bypass SSO and prompt the native Moodle auth form: this allow a recovery access mode for administrators and pose no security problem in a well configured system
• with dual login disable, user is always redirect to SSO as in the current plugin release
• with dual login enable, user switch to the native Moodle auth form with the additional button for SSO as in the Henrik's contribute

[mfprimo]

Ops... 4cf1590 commit as-is breaks the semantics of dual-login option (see above). I was being suggesting to accept a modified version of the contribute.

[dmirandaa]

Yes, I'll test and change before release e new version, I merged just to resolve the conflicts