dmirandaa / moodle-auth_saml2sso

Moodle plugin for authentication using a SimpleSAMLphp Service Provider
https://moodle.org/plugins/auth_saml2sso
0 stars 6 forks source link

Error in stringMapping in the constructor in auth.php #18

Closed neeesn closed 6 years ago

neeesn commented 6 years ago

Describe the bug There is an error in the constructor

It calls $this->mapping = (object) self::$stringMapping; but the function is public static $stringmapping with an lower m.

I have corrected the uppercase M to lower case m in the constructor, and now its working.

To Reproduce Just install the plugin in moodle 3.4.3

Expected behavior No error

Additional context It seems when updating from Moodle.org its another version up there that makes our page go in circles, because it could not install. But when we got the version from Master on github, it worked ( Almost except from the error describd above)

Thanks for doing a good job on the plugin.