Wrong semantic for moodle_mapping option - Githubissues

dmirandaa / moodle-auth_saml2sso

Moodle plugin for authentication using a SimpleSAMLphp Service Provider

https://moodle.org/plugins/auth_saml2sso

0 stars 6 forks source link

Wrong semantic for moodle_mapping option #27

Closed mfprimo closed 5 years ago

mfprimo commented 5 years ago

The module check for the presence of a user in this way:

from the IdP, the uid is get from the attribute specified by the option idpattr
in Moodle, it is search a user with the uid value in the field specified by the option moodle_mapping
moodle_mapping could be one of username, idnumber or email
if the user is not found, a new user with the username value uid is created
if field mapping is set correctly, uid is also saved in the right field idnumber or email

As result, it is possible e.g.

using the mail foo@example.com from the IdP as user identifier
checking if a user with foo@example.com address exists
if not found, create a new user with foo@example.com as Username and no value in email address

I think this is not the expected behaviour.