search

dmitric / DLCImagePickerController

ImagePickerController with live filters, radial blur and more. Brought to you by Backspaces.
www.backspac.es
BSD 3-Clause "New" or "Revised" License
1.56k stars 320 forks source link

blurring crashes on iOS6 #11

Closed fireblue closed 12 years ago

fireblue commented 12 years ago

Hi, great job! But it seems that when you apply blur to a photo, then shoot, the program exits without any trace, even with Xcode. Sorry about my poor English.

I'm using iOS6 with iPhone 4S

thank you very much about your great work!

wylieconlon commented 12 years ago

Thanks for the feedback! We haven't tested this at all on iOS 6, so it's not unexpected that there might be some crashes (we've had issues with this before).

@sujal, do you have any thoughts, or are you able to replicate this? I understand the lack of trace might complicate things.

Anyway, thanks for the report!

sujal commented 12 years ago

No ideas on this one yet, but I do see the crash. Will let you know if I find anything.

Sujal

On Sep 2, 2012, at 2:24 PM, Wylie Conlon notifications@github.com wrote:

Thanks for the feedback! We haven't tested this at all on iOS 6, so it's not unexpected that there might be some crashes! We've had issues with this before.

@sujal, do you have any thoughts, or are you able to replicate this? I understand the lack of trace might complicate things.

Anyway, thanks for the report!

— Reply to this email directly or view it on GitHub.

dmitric commented 12 years ago

Wonder if it's happened since GPUImage updates I've pulled. I'll check when I'm at my iOS dev setup

sujal commented 12 years ago

So, everything I'm seeing shows a low memory crash. Restarting the phone makes it crash a little less, but it's still 90% with the blur filter on. I'm still trying to piece together what's happening/what's changed, but it's a lower priority for me right now.

dmitric commented 12 years ago

I can confirm this on iO6 now. I think I might make the image a bit smaller, as supposedly it solves this problem -- eg making it 2048x2048.

luosky commented 12 years ago

I am having this problem too.

dmitric commented 12 years ago

Just so you guys know, the best way to fix is to just constrain the image using the crop filter a bit more. 83% on the width and height works. I tried using a dummy filter and used the forceProcessingAtSize but it slowed the whole thing down a lot.

I will commit fix once my internet isn't so wonky #sandy

dmitric commented 12 years ago

latest commit should fix this for now

nihtin9mk commented 11 years ago

I have downloaded the zip.But GPUImage is missing..why ??