Closed wodka closed 3 years ago
Hi, thanks for the feedback. The problem is fixed in version 1.4.5 which is already available on npm
just tried it out.
but it still installs the additional node_modules:
I have tried it and it also works with the 8.0.5 version of nestjs - I forced this by adding the resolutions to package.json:
"resolutions": {
"@nestjs/common": "8.0.5",
"@nestjs/core": "8.0.5",
"@nestjs/platform-express": "8.0.5",
"@nestjs/testing": "8.0.5"
},
so perhaps it might also fix the problem to add the dependencies for nestjs 7 + 8 and allow it in the peer dependencies with the same version
Are you using yarn? I didn't find any documentation at docs.npmjs.com for the resolutions object in package.json I'll set up peerDependencies to avoid duplication
yes I'm using yarn - thought there is a similar thing with npm as well^^
I have configured peerDependencies, try version 1.4.7 with npm
just tried it - it now also with yarn no longer installs the sub packages! thank you for changing this.
Thank you for noticing this 🙂
I'm still facing this on 8.0.0
it seems like nestjs 8 will require peerDependencies to be set so that no second version of nestJs core get installed.
else it will fail with: