search

dmitriy-nz / nestjs-form-data

NestJS middleware for handling multipart/form-data, which is primarily used for uploading files.
https://www.npmjs.com/package/nestjs-form-data
MIT License
117 stars 23 forks source link

support NestJS v8 #19

Closed micalevisk closed 2 years ago

micalevisk commented 2 years ago

Hi! can you please try to support the latest major version of NestJS?

https://github.com/dmitriy-nz/nestjs-form-data/blob/b53fca4c0d92665e542672da1512f711b4ee10df/package.json?#L44-L45

dmitriy-nz commented 2 years ago

Hi! I will check it soon

dmitriy-nz commented 2 years ago

Nestjs v8 support has been updated

micalevisk commented 2 years ago

if it still work for nestjs v7, then you'll need to change the peer deps semver range. Also, as nestjs v8 requires rxjs v7, you'll need to change that peer deps as well:

"@nestjs/common": "^7.3.0 || ^8.0.0",
"@nestjs/core": "^7.3.0 || ^8.0.0",
"rxjs": "^6.6.3 || ^7.1.0"
micalevisk commented 2 years ago

I guess it would be even better if you bump all @nestjs/* (and rxjs) of your deps and dev deps, just to make sure the tests are still passing for nestjs v8 :)