search

dmitry-ivanov / laravel-console-mutex

Mutex for Laravel Console Commands.
MIT License
139 stars 31 forks source link

New MySQLPDOLock class on NinjaMutex and MySQL driver with options #28

Closed rafacouto closed 2 years ago

rafacouto commented 2 years ago

This PR allows to use the mysql strategy and set options with the PDO driver.

It was motivated by the need of connecting to a MySQL/MariaDB server with the SSL/TLS option required. If that option is rightly configured in your Laravel's database config this patch uses the database.connections.mysql.options setup transparently.

NinjaMutex master branch is required to pass the options parameter. Last release of arvenil/mutex at this PR moment is 0.6 so that composer dependency is dev-master#82cbb2c (Feb 1, 2021). If a new release of NinjaMutex is published it should be set on this composer.json.

dmitry-ivanov commented 2 years ago

Hi @rafacouto,

Thank you for your contribution!

I'll try to take a look at it soon (hopefully this weekend).

codecov[bot] commented 2 years ago

Codecov Report

Merging #28 (e2daa2c) into master (be2a704) will not change coverage. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master       #28   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        23        23           
===========================================
  Files              2         2           
  Lines             58        60    +2     
===========================================
+ Hits              58        60    +2
Impacted Files Coverage Δ
src/Mutex.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be2a704...e2daa2c. Read the comment docs.

dmitry-ivanov commented 2 years ago

Looks good, thanks 👍