search

dmitry-ivanov / laravel-console-mutex

Mutex for Laravel Console Commands.
MIT License
139 stars 31 forks source link

added file mutex directory. #6

Closed lesstif closed 6 years ago

lesstif commented 6 years ago

as it is possible to change file mutex saved directory.

dmitry-ivanov commented 6 years ago

Hey, @lesstif !

Thanks for your suggestion and PR! I think adding config var in app config file would be a little bit inconsistent for the package. We already have few settings like strategy, timeout which are controlled by command fields/methods.

Maybe I'll add separate config file for the package later, if it would be needed. Then it would be possible to set strategy/timeout/file storage in one place for all commands.

But for now, I've just added getMutexFileStorage in trait, which you can override, if needed: https://github.com/dmitry-ivanov/laravel-console-mutex#custom-mutex-file-storage

Released 5.5.1. Thanks!

lesstif commented 6 years ago

you are correct. 👍 thanks!