Fix inverted conditions in DateSpecifier

[aaubry]

The conditions in the DateSpecifier constructor are inverted, causing queries such as --begin 'since 7 days ago' reg to be filtered incorrectly. When the traits are null (or omitted), the intention is to include every component of the date, but currently no components are used. In the original source, the conditions are different:

  date_specifier_t(const date_t& date,
                   const optional<date_traits_t>& traits = none) {
    if (! traits || traits->has_year)
      year = date.year();
    if (! traits || traits->has_month)
      month = date.month();
    if (! traits || traits->has_day)
      day = date.day();

    TRACE_CTOR(date_specifier_t, "date_t, date_traits_t");
  }

This fix inverts the logic to match the original source code, and makes the above query work as intended.

[dmitry-merzlyakov]

Hi @aaubry Thank you for a good catch - the matter of the request and changes are absolutely clear.

Could you, please, make some small adjustments before completing the PR:

• Please, target your PR to /nledger/tree/next-dev-0.8.6 - this branch accumulates all changes for the next version. At this moment, it is mostly identical to Master, so it should not cause any problems.
• If possible - could you, please, also add a test for your modification? Since this is NLedger issue, it may go to /Contrib/test/nledger/ with any convenient name (e.g. nl-issues-2.test or whatsoever). If writing a ledger-format test is difficult - you can create a unit test in /Source/NLedger.Tests/Times/DateSpecifierTests.cs (you will need to create the file).

Let me know if you need any assistance. Thank you!

[aaubry]

Sure, no problem. I'll try to do that still today. Thanks!

[aaubry]

I'm closing this because I don't think I can change the target branch. I've opened https://github.com/dmitry-merzlyakov/nledger/pull/39 instead.