search

dmitry-solomadin / skwibl

Realtime collaboration service.
http://skwibl.com
1 stars 0 forks source link

New scale types: "fit to width", "fit to screen" #181

Closed dmitry-solomadin closed 11 years ago

dmitry-solomadin commented 11 years ago

New scale types: "fit to width", "fit to screen"

dmitry-solomadin commented 11 years ago

I've added "Fit to image" scale type. This would be enough for beta.

yuri-karadzhov commented 11 years ago

It should be default scale, but there is a problem with scale when you load the image. Image is not centered.

dmitry-solomadin commented 11 years ago

BTW, "fit to image" should be disabled if the image is not present on current canvas.

yuri-karadzhov commented 11 years ago

Yes and it should be called "fit to page" not "fit to image"

dmitry-solomadin commented 11 years ago

"fit to page" is good name when there is actual page present, I think that image is far more descriptive because user understands that the screen will fit the image he uploaded. He might not understand what the page is.

yuri-karadzhov commented 11 years ago

The page is web page user visit, so you scale your image that it fit to this page. It sounds strange if you scale your image that it fit to image and you always scale content not canvas itself.