search

dmitry-solomadin / skwibl

Realtime collaboration service.
http://skwibl.com
1 stars 0 forks source link

Add uglification before deploy #182

Closed yuri-karadzhov closed 11 years ago

yuri-karadzhov commented 11 years ago

We should uglify our js to avoid problems with preply monkeys.

yuri-karadzhov commented 11 years ago

Now it's broken. There is some problem in client script. App.room.canvas is undefined

yuri-karadzhov commented 11 years ago

The files in room directory should be concatenated in the specific order: history canvas item other Should I hardcode concatenation order or it is better to rename this files like 00_history 01_canvas 02_item and so on

dmitry-solomadin commented 11 years ago

I think it's better to hard code the order. I will fix the scripts later so they won't be order-dependent.

yuri-karadzhov commented 11 years ago

There are lots of files, so I think it's better to rename 3 files temporary rather then hardcode all 20. When you fix the problem with order you are welcome to rename them.

So I rename only 3 files 00_history 01_canvas 02_item it is enough to fix the problem.

dmitry-solomadin commented 11 years ago

Actually the order is wrong. I fixed it. Anyway there is no good way to fix this problem from the javascript and I don't want to write additional code to make things work from client side. The more reliable and traditional way would be either to create a file that will describe the order or to perserve order inside uglifying cycle.

yuri-karadzhov commented 11 years ago

Done for js. Should compress css too.