search

dmitry-solomadin / skwibl

Realtime collaboration service.
http://skwibl.com
1 stars 0 forks source link

Actions should not contain user instance #206

Open yuri-karadzhov opened 11 years ago

yuri-karadzhov commented 11 years ago

First of all it is really bad idea to add user info to all actions. You should keep all user info on the client side and pass only id. Second - user info contains user password if you use db.users.findById.

You should always ask me for advice if you going to do smth on the server side.

dmitry-solomadin commented 11 years ago

Yes, I knew that this was a bad idea, it was made so to make this feature faster, it is kind of easy to refactor that part of code. I will do this after beta.

yuri-karadzhov commented 11 years ago

I changed db.users.findById to db.contacts.getInfo