dmitry-viskov / pylti1.3

LTI 1.3 Advantage Tool
MIT License
111 stars 60 forks source link

set timeouts on requests calls #127

Open hmoffatt opened 5 months ago

hmoffatt commented 5 months ago

pylti1.3 uses requests to interact with the tool consumer, but does not set any timeout on the requests calls. As per the documentation, timeouts should always be set in production. https://docs.python-requests.org/en/latest/user/advanced/#timeouts

Requests may introduce a default in the future, but currently has none. See https://github.com/psf/requests/issues/3070