search

dmitry-viskov / pylti1.3

LTI 1.3 Advantage Tool
MIT License
111 stars 60 forks source link

Add support for Resource Link Membership Service #86

Closed cmurtaugh closed 1 year ago

cmurtaugh commented 1 year ago

The IMS spec for the Names and Roles Provisioning Service also defines a Resource Link Membership Service:

Optionaly, a platform may offer a Resource Link level membership service. The endpoint is the same as the context membership service. The tool needs to append an additional query parameter rlid with a value of the Resource Link id as communicated in LtiResourceLinkRequest https://purl.imsglobal.org/spec/lti/claim/resource_link claim.

This PR adds an optional resource_link_id argument to NamesRolesProvisioningService.get_members() that will be passed to the NRPS context membership service in the rlid query string parameter.

Closes #85.

cmurtaugh commented 1 year ago

Hi @dmitry-viskov, I'm wondering if you have any feedback on this PR or if it would be possible to have it merged. Thanks!

joerou commented 1 year ago

Looking for this as well, thanks @cmurtaugh for the PR, also bumping @dmitry-viskov if this could be merged and released?

dmitry-viskov commented 1 year ago

hi @cmurtaugh . Thanks for your contribution! Sorry for delay. I've merged your PR but as I could see you re-implemented existing function add_param_to_url. I've changed your code a little: https://github.com/dmitry-viskov/pylti1.3/pull/97