N+1 query

[zareismail]

Hi. Thanks for the amazing package.

But there is a bug that causes the N+1 query on the index view. The default mediaOnIndex callback:

 // At line 130

 function (HasMedia $resource, string $collectionName) use ($mediaOnIndex): Collection {
        return $resource->media()->where('collection_name', $collectionName)
                         ->limit($mediaOnIndex)
                         ->orderBy('order_column')
                         ->get();
  }

Do not check the loaded media relationship. This causes N+1 query on index view that can be changed like the below:

 // Uses laravel auto eager loading if not loaded

 function (HasMedia $resource, string $collectionName) use ($mediaOnIndex): Collection {
        return $resource->media->where('collection_name', $collectionName)
                         ->limit($mediaOnIndex)
                         ->sortBy('order_column');
  }

[dmitrybubyakin]

@zareismail Hi. You can pass a custom media resolver to mediaOnIndex https://github.com/dmitrybubyakin/nova-medialibrary-field#mediaonindex

[zareismail]

@zareismail Hi. You can pass a custom media resolver to mediaOnIndex https://github.com/dmitrybubyakin/nova-medialibrary-field#mediaonindex

Yeah. I know. But I think this default value is wrong and many developers will never notice it

[dmitrybubyakin]

@zareismail Does limit work with the eager loading?

[zareismail]

@zareismail Does limit work with the eager loading?

I think, no. you can change it like this:

$resource->relationLoaded('media') || $resource->load(['media' => function($query) use ($limit) {
$query->limit();
});

return $resource->media->where('collection_name', $collectionName) ...

[dmitrybubyakin]

@zareismail Thank you. I'll think about that.