search

dmitrybubyakin / nova-medialibrary-field

Laravel Nova field for managing the Spatie media library
MIT License
262 stars 62 forks source link

Nova 4 support #157

Closed illambo closed 4 months ago

illambo commented 2 years ago

Any plan about support for laravel nova 4? Thanks

dmitrybubyakin commented 2 years ago

@illambo Hi, don't really have time to support this package

illambo commented 2 years ago

Ok thanks

ChristianPavilonis commented 2 years ago

I see this fork with a few commits for Nova 4. You may want to try that out.

theimerj commented 2 years ago

Hello, I will open a PR in the following days. I am getting quite close here. Apart from other stuff I still have to make generated conversions work, fix tests and so on. But if someone wants to try it with Nova 4 installation, the crucial parts are working ok now.

sp4r74cus commented 2 years ago

hi @theimerj Thank you for the efforts to make this compatible with Nova 4!

I couldn't find where to open an issue in your fork. so i'll add it here.

the id of the field is not generated correctly, it's id="inputundefined" and when having multiple fields in the same resource only the first one works.

Screen Shot 2022-05-01 at 12 54 48
theimerj commented 2 years ago

Hello @sp4r74cus, I opened the issue tab in the fork, so we can move the conversation there.

theimerj commented 2 years ago

Hello everyone, the PR #160 just landed. Please help out with testing and adjustments, if you can. It is not 100% done, it still needs quite some polishing.

@dmitrybubyakin could you please remove the #159 i accidentally created from wrong branch? Thank you.

tmartty commented 2 years ago

any news on this?

theimerj commented 2 years ago

any news on this?

Actually yes, @kreejzak is looking into it and we will merge soon.