search

dmitrybubyakin / nova-medialibrary-field

Laravel Nova field for managing the Spatie media library
MIT License
262 stars 62 forks source link

Fix autocompletion error on Medialibrary-Field #178

Closed riyuk closed 1 year ago

riyuk commented 1 year ago

Currently PhpStorm only offers the default behaviour when using Medialibrary::make which is $name, $attribute, $resolveCallback. Since we have different properties on this field we should update the docs for that.

With this comment PhpStorm isn't crying anymore and we have proper autocompletion instead of marking it as wrong/error when calling Medialibrary::make

riyuk commented 1 year ago

Hey. Since this pull request isn't introducing any particular code changes or new code is there a chance to get it merged anytime @dmitrybubyakin ?

dmitrybubyakin commented 1 year ago

@riyuk thanks for the PR https://github.com/dmitrybubyakin/nova-medialibrary-field/releases/tag/4.0.4