dmitryd / dd_deepl

3 stars 10 forks source link

Symfony v. 7 incompatibility #14

Closed schmidt-oliver closed 8 months ago

schmidt-oliver commented 9 months ago

After updating my packages also the Symfony packages where updated.

  - Upgrading symfony/console (v6.4.3 => v7.0.3)
  - Upgrading symfony/dotenv (v5.4.35 => v7.0.3)
  - Upgrading symfony/process (v6.4.3 => v7.0.3)

Looks like there is an incompatibility with the latest changes of Symfony, because they added return types in its functions.

Fatal error: Declaration of Dmitryd\DdDeepl\Command\ManageDeeplGlossariesCommand::execute(
Symfony\Component\Console\Input\InputInterface $input,
Symfony\Component\Console\Output\OutputInterface $output
)

must be compatible with

Symfony\Component\Console\Command\Command::execute(
Symfony\Component\Console\Input\InputInterface $input,
Symfony\Component\Console\Output\OutputInterface $output
): int

in ../vendor/dmitryd/dd-deepl/Classes/Command/ManageDeeplGlossariesCommand.php on line 88

This is one of the errors. All inherited functions probably need to be changed. Would be great if there will be a fix soon.

dirnbauer commented 8 months ago

maybe this helps? https://blog.t3bootstrap.de/2024/02/derzeitige-inkompatibilitaet-mit-extensions-die-symfony-command-verwenden/

dmitryd commented 8 months ago

Thank you for reporting. It will be released soon.

schmidt-oliver commented 8 months ago

Thank you :)