search

dmitryd / dd_deepl

3 stars 10 forks source link

Error when translating page #30

Closed hannesbochmann closed 6 months ago

hannesbochmann commented 7 months ago

I have a pretty empty TYPO3 12.4 installation with PHP 8.3. There are some pages that have almost no data except a title. As soon as I translate a page I get the following PHP error:

Dmitryd\DdDeepl\Event\CanFieldBeTranslatedCheckEvent::__construct(): Argument #3 ($fieldValue) must be of type string, null given, called in /var/www/html/vendor/typo3/cms-core/Classes/Utility/GeneralUtility.php on line 2985

This happens due to fields that have no value and are NULL therefore. In my case it's the rowDescription field. But it's only the first. When I insert something into it the next field without a value pops up. As the methods that instantiate CanFieldBeTranslatedCheckEvent accept the $fieldValue variable to be NULL the class should except that, too. At least I think to. I will provide a PR.

dmitryd commented 6 months ago

Thank you very much for the report and the fix!