dmitryikh / leaves

pure Go implementation of prediction part for GBRT (Gradient Boosting Regression Trees) models from popular frameworks
MIT License
432 stars 72 forks source link

Support for newer versions of XGBoost #80

Open Ponewor opened 3 years ago

Ponewor commented 3 years ago

Something has changed in XGBoost model's binary format. The highest versions I've managed to make leaves work with is 1.0. Starting from 1.1+ I keep getting "panic: unexpected EOF". Is support for newer versions planned? Moreover, they've started to save models in JSON format and it looks like they're going to deprecate binaries altogether.

nikolaydubina commented 3 years ago

Same error here with XGB 1.3.3. This fails.

image image

Size is too large here:

image

@dmitryikh, I think format for XGB binary changed.

nikolaydubina commented 3 years ago

Might be better to add support for JSON? https://xgboost.readthedocs.io/en/latest/tutorials/saving_model.html