dmitryserbin / azdev-release-orchestrator

Azure DevOps extension to manage and orchestrate release pipelines
MIT License
23 stars 12 forks source link

Random error - Unable to get release progress #31

Closed foliv57 closed 4 years ago

foliv57 commented 4 years ago

Hi,

I randomly get the error "Unable to get XXX release progress" on release orchestrator tasks during deployment.

The setup of my task is:

My release pipeline is just a succession of orchestrator tasks with the same setup (except the release definition name for sure).

Attached, the log: Error.log

If I redeploy the release, it pass (or randomly failed on another release orchestrator deployment task).

When the error occurs, if I check the targeted release, it was successfully deployed.

Regards

foliv57 commented 4 years ago

I checked the code in "/OrchestratorV1/helper.ts". Why there is no "await" at line 437 on "return this.releaseApi.getRelease" which is an async method ?

dmitryserbin commented 4 years ago

Thanks for reposting this. Wondering how often the error occurs? Line 437 looks a lot like a bug and might be related to the issue. I will look into it and release a bugfix within the next few days.

foliv57 commented 4 years ago

Thank you for the quick answer. In my staging environment with a small POC of 3 simple and fast releases, never. But in my production environment with an orchestration of 12 complex and long releases, it appends 2 times for 5 deployment attempts. Maybe just a coincidence but all errors append with the real time job execution log open to follow the deployment.

foliv57 commented 4 years ago

To give you also more context, all targeted releases have an approval and during my tests the targeted stages was in status « waiting for approval » before orchestration deployment start

dmitryserbin commented 4 years ago

Thanks for the details. If you could reproduce the issue in debug mode that would be awesome. To do that, simply add DEBUG=release-orchestrator:* to the pipeline variables.

dmitryserbin commented 4 years ago

I checked the code in "/OrchestratorV1/helper.ts". Why there is no "await" at line 437 on "return this.releaseApi.getRelease" which is an async method ?

This is now addressed in #32

foliv57 commented 4 years ago

Hi, I captured the bug in debug mode this morning. Attached, the log file: Bug31_debug.log

dmitryserbin commented 4 years ago

Thanks for that. Seems like getReleaseRetry causing the issue. Weirdly, I have never seen this before, and we're using Orchestrator a lot here.

Anyhow, I will release 1.2.6 later today, please give it a go.

dmitryserbin commented 4 years ago

Let me know if I can close this issue @foliv57

foliv57 commented 4 years ago

At this time it looks good. No errors since the fix. Let me just wait Tuesday 28, we have a production release. If it pass we can close the bug

dmitryserbin commented 4 years ago

Yep sounds good @foliv57

foliv57 commented 4 years ago

Hi @dmitryserbin, Release successfully deployed. It's now stable with the fix. Thank you again for the really fast resolution.