search

dmitryserbin / azdev-release-orchestrator

Azure DevOps extension to manage and orchestrate release pipelines
MIT License
23 stars 12 forks source link

Fix definitionId filter support #94

Closed matteopessina closed 11 months ago

matteopessina commented 1 year ago

When definitionName is populated with the pipeline definition id, then it filter the releases by pipeline id.

matteopessina commented 1 year ago

It needs smoke test before being ready.

matteopessina commented 1 year ago

Hi @dmitryserbin, I created unit tests for changes but I cannot easily set up an environment for smoke test. In case you already have one, could you please make a smoke test?

dmitryserbin commented 1 year ago

Hi @dmitryserbin, I created unit tests for changes but I cannot easily set up an environment for smoke test. In case you already have one, could you please make a smoke test?

Thanks for your contribution. I will have a look and run smoke tests shortly.

dmitryserbin commented 1 year ago

Pls fix linting issues when you have a moment?

matteopessina commented 1 year ago

Pls fix linting issues when you have a moment?

Done. @dmitryserbin

matteopessina commented 11 months ago

Hi @dmitryserbin, is there something else that should be done on this PR? Can I help?

azure-pipelines[bot] commented 11 months ago

No commit pushedDate could be found for PR 94 in repo dmitryserbin/azdev-release-orchestrator

dmitryserbin commented 11 months ago

/azp run Orchestrator-CI

azure-pipelines[bot] commented 11 months ago
Azure Pipelines successfully started running 1 pipeline(s).
dmitryserbin commented 11 months ago

Hi @dmitryserbin, is there something else that should be done on this PR? Can I help?

sorry got distracted with work. will test and release asap.

dmitryserbin commented 11 months ago

should be good to go, merge it when you're ready. i'll release it shortly after.

matteopessina commented 11 months ago

should be good to go, merge it when you're ready. i'll release it shortly after.

Hi @dmitryserbin, I cannot merge. Could you do that for me?

image

dmitryserbin commented 11 months ago

Hi @dmitryserbin, I cannot merge. Could you do that for me?

all good now

dmitryserbin commented 11 months ago

I'll tag you here when it's released @matteopessina. Thanks a lot for your contribution!

matteopessina commented 11 months ago

I'll tag you here when it's released @matteopessina. Thanks a lot for your contribution!

You are welcome! Thank u for the task

dmitryserbin commented 11 months ago

Released under v3.1.1888