dmitrysmagin / dmenu

Automatically exported from code.google.com/p/dmenu
3 stars 4 forks source link

Codebase patch #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This is a patch to the codebase with the following changes/enhancements:

   1) The file selector now shows an '..' entry for every folder above root
   2) The WorkDir is now separate from the SelectorDir.  The Selector Dir
is the path where the File Selector starts (as the workdir isn't
necessarily tied to where the input files are).  
   3) You can persist the current directory of the File Selector to
overwrite the saved SelectorDir.  This means that a user can define the
SelectorDir at runtime by pressing 'start' in any given folder.
   4) Minor memory leaks caught and cleaned up
   5) All resources that are used at runtime within the menu are now
absolute paths.  This removes the need for '../' to be in the code and
makes it clear what files are being loaded and from where.
   6) Minor cleanup of constant usage, enforcing use of Enums where applicable
   7) Reworked UI code to consolidate duplicate code to make changes and
enhancements simpler
   8) Added some minor macros to help with object creation

Original issue reported on code.google.com by timothy....@gmail.com on 1 Nov 2009 at 9:50

Attachments:

GoogleCodeExporter commented 9 years ago
So for some reason the readme is being listed as binary, so I'm adding the 
contents here:

--------------------------------------------------------
Download files.tgz to root of source trunk
Change dir to root of source trunk

Extract files.tgz:    tar -xzvf files.tgz
Patch file:           patch -p0 -d dmenu < fileset.patch

Original comment by timothy....@gmail.com on 1 Nov 2009 at 9:55

GoogleCodeExporter commented 9 years ago
Hello Tim.

This is 1@qbQD4T5Z0949.

I'm testing your patch now.
But I got Segmentation fault...
I attach my doing logs. 
So please tell me Where do I wrong with your patch ?

Original comment by leo.5xl.bigfat on 2 Nov 2009 at 6:05

Attachments:

GoogleCodeExporter commented 9 years ago
It looks like the issue is with the themes folder.  I have some code that tries 
to
write the theme file out, and it is having some issues with the merged conf 
files. 
Try deleting the themes folder, and doing an SVN update to get the files from 
the
repository.  That should solve the problem.

Original comment by timothy....@gmail.com on 2 Nov 2009 at 6:10

GoogleCodeExporter commented 9 years ago
This is 1@qbQD4T5Z0949.

First, I use your patched theme.cfg with themes folder from SVN.
In your theme.cfg file, there are 7 "/home/tim/Dingux/dmenu-ro", so I rewrite 
all 
"/home/tim/Dingux/dmenu-ro" to "/usr/local".
But I got Segfault.

Second, I use theme.cfg which got from SVN.
And I got Segfault again...

/boot/local/dmenu # ./dmenu 
src/conf.c     ( 291): Not supported - dmenu.cfg contains SubMenuItems          

in directory /usr/local/dmenu/sample_search_dir/app1
Success
src/common.c   ( 208): Opening file: /usr/local/home/.dmenu/fontcolor.ini
src/common.c   ( 208): Opening file: timidity.cfg
Segmentation fault

Is this a problem on themes folder ?

Another problem, I can't test dmenu-host build because some file path use $HOME.
$HOME values are different in PC-Linux and DINGUX.

Original comment by leo.5xl.bigfat on 2 Nov 2009 at 9:29

GoogleCodeExporter commented 9 years ago
When you say PC Linux, I assume you are talking about cygwin?  If not, I am
developing only on my PC which is running Linux. 

Original comment by timothy....@gmail.com on 2 Nov 2009 at 1:51

GoogleCodeExporter commented 9 years ago

Original comment by leo.5xl.bigfat on 6 Nov 2009 at 2:17