search

dmitrystu / libusb_stm32

Lightweight USB device Stack for STM32 microcontrollers
Apache License 2.0
721 stars 165 forks source link

Add CCID support #127

Open kidbomb opened 1 year ago

kidbomb commented 1 year ago

@dmitrystu Any chance of getting this merged?

dmitrystu commented 1 year ago

Sorry for the very late reply. I need to check specs. https://www.usb.org/sites/default/files/DWG_Smart-Card_CCID_Rev110.pdf.

kidbomb commented 1 year ago

Thanks for the review @dmitrystu - those are fixed.

dmitrystu commented 1 year ago

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

kidbomb commented 1 year ago

Just added all messages now

kidbomb commented 1 year ago

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

Any extra feedback on this?

kidbomb commented 1 year ago

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

Any extra feedback on this?

@dmitrystu - Is there anything else you believe is missing? I would like to have this PR merged soon so I can start working on a feature for Flipper Zero

kidbomb commented 1 year ago

@dmitrystu - reminder