search

dmitrystu / sboot_stm32

Secure USB DFU1.1 bootloader for STM32
Apache License 2.0
303 stars 63 forks source link

refactoring of encryption commands #18

Open fizzyade opened 4 years ago

fizzyade commented 4 years ago

I think it makes sense to refactor the encryption, currently the software uses aes_init aes_encrypt etc as function names regardless of whether aes encryption is used, it might actually be blowfish or something else that is actually being used.

Something like the following might give the code a bit more clarity:

eal_init eal_encrypt eal_decrypt

(Encryption Abstraction Layer)

It's just a thought and something that's been bugging me in the back of my mind for months, the whole project is very well written and this "misnaming" (probably for historical reasons) just doesn't seem in keeping with your own high standards.

I know it's a minor thing and it makes no difference to functionality, but I personally think it will bring an improvement to the code base.

dmitrystu commented 4 years ago

BTW. AES is not an actual name of the cipher. It is Rijndael.