dmjio / stripe

:moneybag: Stripe API
http://hackage.haskell.org/package/stripe-haskell
177 stars 74 forks source link

Bump aeson upper bound to 1.1.* #53

Closed WillSewell closed 8 years ago

WillSewell commented 8 years ago

This makes it compatible with the latest stackage nightly (nightly-2016-10-26).

dmjio commented 8 years ago

@WillSewell,

Can you explicitly avoid aeson version 0.10.0.0.

>= 0.8  && < 0.10 || >= 0.11 && < 1.1 -- EDIT

I'd commit a change with the above (test first if you could), then rebase off master, and fixup/squash the last commit.

dmjio commented 8 years ago

@WillSewell, Oh, and thanks :)

dmjio commented 8 years ago

There's probably quite a few deps. that need to be upgraded.

WillSewell commented 8 years ago

No problem @dmjio. Just checking if you did mean >= 0.8 && < 0.10 || >= 0.11 && < 1.2 and not >= 0.8 && < 0.10 || >= 0.11 && < 1.1? Since 1.1.* hasn't been released yet.

WillSewell commented 8 years ago

I guess the title is misleading. It's a non inclusive upper bound. Oops.

dmjio commented 8 years ago

@WillSewell, ah yes, that's what I meant :)

dmjio commented 8 years ago

Thought 1.1 was latest for some reason

WillSewell commented 8 years ago

Ok, updated :)

dmjio commented 8 years ago

@WillSewell, awesome, thanks :) Don't worry about the CI, I'll fix that.