dmkoelle / jfugue

Java API for Music Programming
80 stars 11 forks source link

Player.play and MidiFileManger.savePatternToMidi() functions do not handle chord inversions correctly when only one chord is in the music string #13

Open guitarmanseven opened 9 months ago

guitarmanseven commented 9 months ago

When using the Player.play() and MidiFileManager.savePatternToMidi() functions the following midi strings are not playing / saving correctly:

player.play("D4min7^w"); player.play("D4min7^^w"); player.play("D4min7^^^w");

The wonky behavior is that the player plays a chord followed by a single note.

I have tried many variations, but the inversions only seem to work when you have multiple chords in the string.

These strings work: player.play("C3majw C3maj^w C3maj^^w"); player.play("D4min7w"); // not an inversion, but just for reference

Any help would be greatly appreciated. I am trying to debug as well to find the issue.

Thank you!

dmkoelle commented 9 months ago

That is certainly odd behavior. I'll see what I can figure out.

On Thu, Nov 16, 2023 at 7:54 AM guitarmanseven @.***> wrote:

When using the Player.play() and MidiFileManager.savePatternToMidi() functions the following midi strings are not playing / saving correctly:

player.play("D4min7^w"); player.play("D4min7^^w"); player.play("D4min7^^^w");

The wonky behavior is that the player plays a chord followed by a single note.

I have tried many variations, but the inversions only seem to work when you have multiple chords in the string.

These strings work: player.play("C3majw C3maj^w C3maj^^w"); player.play("D4min7w"); // not an inversion, but just for reference

Any help would be greatly appreciated. I am trying to debug as well to find the issue.

Thank you!

— Reply to this email directly, view it on GitHub https://github.com/dmkoelle/jfugue/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANX4LMV6KZRKSOSRI64TJDYEYEIBAVCNFSM6AAAAAA7ODOBPSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TMNZZGU4TOOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>