search

dmlc / HalideIR

Symbolic Expression and Statement Module for new DSLs
Other
205 stars 59 forks source link

Some symbols now need to be explicitly exported #44

Closed Anthony-Mai closed 5 years ago

Anthony-Mai commented 5 years ago

Previous the build default to export all symbols, which is inefficient, and a change was made to do explicit exports. So now some of the symbols become unresolved external symbols and need to be explicitly exported.

Anthony-Mai commented 5 years ago

The issue was discovered by: http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-2445/9/pipeline/36 The unresolved externals are all from the HalideIR component. For example: ir_functor_test.cc:(.text._ZN3tvm2ir11ExprFunctorIFiRKN8HalideIR4ExprEiEE10InitVTableEv[_ZN3tvm2ir11ExprFunctorIFiRKN8HalideIR4ExprEiEE10InitVTableEv]+0x1b3b): undefined reference to `tvm::Node::TypeKey2Index(char const*)'

ir_functor_test.cc:(.text._ZN3tvm2ir11ExprFunctorIFiRKN8HalideIR4ExprEiEE10InitVTableEv[_ZN3tvm2ir11ExprFunctorIFiRKN8HalideIR4ExprEiEE10InitVTableEv]+0x1b72): undefined reference to `tvm::Node::TypeIndex2Key(unsigned int)' This is needed for pull request: https://github.com/dmlc/tvm/pull/2445