search

dmlc / HalideIR

Symbolic Expression and Statement Module for new DSLs
Other
205 stars 59 forks source link

Add new_expr and free_function to Realize #62

Closed minminsun closed 5 years ago

minminsun commented 5 years ago

"Allocate" has new_expr and free_function, but "Realize" doesn't.

They will be used in our TensorCore IR Passes, which are applied before StorageFaltten and try to set new_expr for some buffer allocations. Before StorageFaltten, buffer allocation is represented by "Realize" instead of "Allocate", that's why we need to add them to "Realize" too.

We plan to open the TVM PR for TensorCore IR Passes in 1 or 2 days. It will be very helpful for reviewers or others to try out the TensorCore IR Passes if this PR can be merged before that. Thank you!

minminsun commented 5 years ago

Hi @tqchen could you please help to review?

tqchen commented 5 years ago

as https://github.com/dmlc/tvm/pull/3533 we have started to evolve TVM's IR and no longer uses HalideIR. please send an RFC and possibly PR there.