dmlc / MXNet.jl

MXNet Julia Package - flexible and efficient deep learning in Julia
371 stars 70 forks source link

opt: decouple OptimizationState from get_momentum and renames #395

Closed iblislin closed 6 years ago

iblislin commented 6 years ago

Blocker: #394

renames:

iblislin commented 6 years ago

Brach diff here: https://github.com/dmlc/MXNet.jl/compare/ib/nadam-sched...ib/opt-getmomentum

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9d60663). Click here to learn what that means. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #395   +/-   ##
=========================================
  Coverage          ?   70.75%           
=========================================
  Files             ?       27           
  Lines             ?     2055           
  Branches          ?        0           
=========================================
  Hits              ?     1454           
  Misses            ?      601           
  Partials          ?        0
Impacted Files Coverage Δ
src/optimizers/sgd.jl 100% <100%> (ø)
src/optimizers/nadam.jl 100% <100%> (ø)
src/optimizer.jl 71.42% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d60663...6fc0b72. Read the comment docs.

iblislin commented 6 years ago

covered in #396