search

dmlc / XGBoost.jl

XGBoost Julia Package
Other
289 stars 110 forks source link

Update to XGBoost v1.5.2 #105

Closed tylerjthomas9 closed 2 years ago

tylerjthomas9 commented 2 years ago

All tests pass when I updated XGBoost_jll to v1.5.2

tylerjthomas9 commented 2 years ago

The checks are failing on windows and osx, I will look at it more tomorrow when I have access to windows/osx devices. These errors are due to Travis using v1.5.4 when Julia's version is set to v1

 julia --color=yes -e "VERSION >= v\"0.7.0-DEV.3630\" && using InteractiveUtils; versioninfo()"

Julia Version 1.5.4

Commit 69fcb5745b (2021-03-11 19:13 UTC)

Platform Info:

  OS: macOS (x86_64-apple-darwin18.7.0)

  CPU: Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz

  WORD_SIZE: 64

  LIBM: libopenlibm

  LLVM: libLLVM-9.0.1 (ORCJIT, ivybridge)

Environment:

  TRAVIS_JULIA_VERSION = 1

  JULIA_PROJECT = @.
ablaom commented 2 years ago

I see even linux is having issues.

@ararslan Is travis testing still supported? It seems that travis in this PR thinks the latest julia is 1.5.4.

ararslan commented 2 years ago

Using version aliases like 1 in Travis will be outdated because they don't seem to have anyone on their end actively merging and deploying community PRs anymore. 1.x for some x should still work though.

ablaom commented 2 years ago

I suggest we switch to GH actions. And happy to make a PR (but I'll need a maintainer or privileges to add public keys / secrets).

ablaom commented 2 years ago

Okay, we've been misled. Github action is already activated but will not run until a maintainer approves the workflow. The problem is that travis has continued to run anyhow, which has confused us.

So will make a PR to remove travis.

ablaom commented 2 years ago

https://github.com/dmlc/XGBoost.jl/pull/106

ablaom commented 2 years ago

@tylerjthomas9 You will want to update the GH action test matrix in .github/workflows/ci.yml by replacing 1.3 with 1.6.

tylerjthomas9 commented 2 years ago

@tylerjthomas9 You will want to update the GH action test matrix in .github/workflows/ci.yml by replacing 1.3 with 1.6.

Done. Let me know if there is anything else I should add to this PR

ablaom commented 2 years ago

@aviks Is there a maintainer who can have a look at this?

aviks commented 2 years ago

I merged #106, so this needs a rebase.

tylerjthomas9 commented 2 years ago

Rebased the PR and replaced the build status icon to the GitHub actions CI status