dmlc / XGBoost.jl

XGBoost Julia Package
Other
288 stars 110 forks source link

hopefully fix docs #121

Closed ExpandingMan closed 1 year ago

ExpandingMan commented 1 year ago

This will hopefully fix the docs, not sure how I missed this line.

cc @rikhuijzer (who has been advising me on package deployment stuff, thanks btw)

rikhuijzer commented 1 year ago

I also now notice that this repository always sets DOCUMENTER_KEY and GITHUB_TOKEN which is uncommon. However, based on the successful CompatHelper-triggered CI runs, the DOCUMENTER_KEY is most likely set so that should work.

aviks commented 1 year ago

Thanks, hopefully this works. I've forgotten how this works these days, I just let Juliahub build and host docs for my packages these days, (but I'm biased 😄 )

rikhuijzer commented 1 year ago

I'm not sure what's going on now. Normally, GitHub Pages takes at most half an hour to update the website once the CI reports that the Pages deploy succeeded and we're now one hour after the CI. The files in gh-pages appear correct also, but GitHub Pages reports Page not found.

My current guess is that the Pages have been disabled for this repository.

Can someone with the right permissions go into the repository settings for this project and verify that the Pages are enabled?

It should look something like this:


image

aviks commented 1 year ago

I don't have access, maybe @trivialfis might be able to help?

trivialfis commented 1 year ago

Apologies, I don't know how the document is deployed for this repository.

ExpandingMan commented 1 year ago

@trivialfis it should only be a github setting to tell it to take the docs page from the gh-pages branch which should already present. See the settings page pictured above.

trivialfis commented 1 year ago

unfortunately, I don't have access to the setting. I help some development for xgboost and its python binding (recently the R binding as well). But CI for xgboost is maintained by @hcho3 , and setting access is restricted to @tqchen and @hcho3 .