search

dmlc / XGBoost.jl

XGBoost Julia Package
Other
288 stars 110 forks source link

make DMatrix constructors more permissive to accommodate table arguments #133

Closed ExpandingMan closed 1 year ago

ExpandingMan commented 1 year ago

This is a more aggressive version of #129.

I got rid of the DataTuple alias altogether as it was not doing anything at this point. It was probably left over from an earlier draft of my big PR. Users are now responsible for making sure tuple types are correct. Also added a test case for an example like the one in the docs.

ExpandingMan commented 1 year ago

(I have merge permission now, so I will merge this myself, but will leave it up for a day or so to give people a chance to comment.)