Open nickrobinson251 opened 1 year ago
i also opened https://github.com/gridap/SparseMatricesCSR.jl/pull/21, and with that SparseMatricesCSR branch the XGBoost.jl tests pass locally on a Julia version built with USE_GPL_LIBS=0
(i've no GPU so no GPU tests run)
I'm not in favor of re-implementing SparseMatricesCSR
in this package, though I'm totally agnostic about which dependency it uses for it as long as it works. The package is used because the DMatrix
returns data in this form. I would say that either try to resolve this in SparseMatricesCSR.jl, or if if you'd like to re-implement it we could potentially switch dependencies.
...due to the dependency on SparseMatricesCSR.jl (added in https://github.com/dmlc/XGBoost.jl/pull/136)
We're running XGBoost.jl in production but have had to fix the XGBoost.jl version to v2.0.2, as the newer versions depend on SparseMatricesCSR.jl, which requires a Julia built with GPL libraries enabled (at Julia build time), causing the following error on our Julia build:
I wonder if the SparseMatricesCSR.jl dependency is necessary and e.g. if there might be an alternative way to achieve the functionality added in #136 without taking on this dependency requiring GPL libraries?