search

dmlc / XGBoost.jl

XGBoost Julia Package
Other
288 stars 111 forks source link

CompatHelper: bump compat for CUDA to 4, (keep existing compat) #165

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

This pull request changes the compat entry for the CUDA package from 3 to 3, 4. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

ExpandingMan commented 1 year ago

@tylerjthomas9 I'm going to wait to see what happens with XGBoost_jll to merge this, since I currently can't get CUDA working with xgboost anymore.

tylerjthomas9 commented 1 year ago

Sounds good. If you are on CUDA 12, you may need this bump to install CUDA.jl so that you can set the runtime version (CUDA.set_runtime_version!) before XGBoost_jll is loaded (however this is just on the CUDA.jl main branch right now, not even 4.0 has this). Otherwise I think that we can only support CUDA 11, which isn't bad because libxgboost doesn't have a CUDA 12 build yet.