search

dmlc / XGBoost.jl

XGBoost Julia Package
Other
289 stars 110 forks source link

demote CUDA and Term to weak dependencies #180

Closed ExpandingMan closed 1 year ago

ExpandingMan commented 1 year ago

This is similar to #176 but it was easier for me to do it in a separate PR.

It seems to be working except that I'm still having major problems with CUDA: for the life of me I can't get it to use the libxgboost with CUDA anymore (I have CUDA 12). @tylerjthomas9 I also pinged you in the other issue... if you can help resolve this in the build tarballs that would be great, I really have no idea what I can do here and it's quite frustrating. It's not just looking at these lines is it? I assume it's more complicated?

In other news, I think testing is going to be quite difficult with weak dependencies, we are really only set up to do unit tests with all dependencies and I think setting up different sets of unit tests is going to be quite hard as there aren't really any tools to help us do that.

devmotion commented 1 year ago

Can you explain the difference to #176 and the reason for this PR? I just checked and tests on #176 pass successfully locally, both on Julia 1.6 and 1.9. #176 also already includes updates of the documentation and follows the general guidelines for naming extensions, in contrast to this PR.

ExpandingMan commented 1 year ago

At the time I wrote this, I believed that #176 did not properly handle checking for the GPU table, but now I realize that is not the case.