search

dmlc / XGBoost.jl

XGBoost Julia Package
Other
288 stars 111 forks source link

allow watchlist to be NamedTuple #199

Closed ExpandingMan closed 8 months ago

ExpandingMan commented 8 months ago

The recent addition of early stopping rounds broke the ability to pass watchlist as NamedTuple. Probably not narrowing the type in the first place was a mistake, and we should have picked one, but in the meantime it would be breaking to remove either. This PR restores the ability to pass watchlist as any iterable of pairs of which the keys can be converted to strings.

See https://github.com/JuliaAI/MLJXGBoostInterface.jl/issues/46#issuecomment-1821235496

rikhuijzer commented 8 months ago

Nice that it's now even covered by a test. Thanks!

rikhuijzer commented 8 months ago

Should we add a MLJXGBoostInterface.jl integration test to this repository?

ExpandingMan commented 8 months ago

I will get it merged if someone wants to do it.