dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.
http://dgl.ai
Apache License 2.0
13.51k stars 3.02k forks source link

Clarify link prediction docs #2670

Closed nguyenhungquang closed 3 years ago

nguyenhungquang commented 3 years ago

📚 Documentation

Tutorial part

On your new tutorial about link prediction, you stated that it followed SEAL model, but what was represented there is just simply applying score function after message passing, which is quite different from SEAL. More particular, SEAL model does not use node feature but node labeling instead, which allows it to apply to inductive setting. Node labeling also requires constructing a local subgraph for each pair of nodes beforehand, then message passing on these graphs, which is really computationally inefficient, and quite difficult to implement.

jermainewang commented 3 years ago

Hi, I think the tutorial follows the practice of SEAL on formulating a link prediction problem as a binary classification problem and the way SEAL prepares positive/negative samples. Yes, I agree we should be more precise on the statement.