Open jermainewang opened 2 years ago
This issue has been automatically marked as stale due to lack of activity. It will be closed if no further activity occurs. Thank you
This issue has been automatically marked as stale due to lack of activity. It will be closed if no further activity occurs. Thank you
🔨Work Item
IMPORTANT:
Project tracker: https://github.com/orgs/dmlc/projects/2
Description
The issue comes up from PR #4454 . The PR introduced a new data structure called
DGLArray
to replaceDLTensor
from DLPack. The follow up action is to further simplify the codebase. Considerations:dgl::runtime::NDArray
,dgl::runtime::NDArray::Container
anddgl::DGLArray
. The question is whether we can consolidate them into one or two classes.dgl/_ffi/runtime_ctypes.py::DGLArray
python class. We need to further decouple it from DLPack and document clearly what each class is about.@yaox12 let's use this thread for discussion.
Depending work items or issues
None