[GraphBolt] Fix DiskBasedFeature Memory Leak Problem - Githubissues

dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.

http://dgl.ai

Apache License 2.0

13.34k stars 3k forks source link

[GraphBolt] Fix DiskBasedFeature Memory Leak Problem #7349

Closed pyynb closed 2 months ago

pyynb commented 4 months ago

Description

Checklist

Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[ ] I've leverage the tools to beautify the python and c++ code.
[ ] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
[ ] All changes have test coverage
[ ] Code is well-documented
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR
[ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

dgl-bot commented 4 months ago

To trigger regression tests:

@dgl-bot run [instance-type] [which tests] [compare-with-branch]; For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

dgl-bot commented 4 months ago

Commit ID: 79368c39bd805745465e025f7969c23465d6fbd5

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: 14092b984a84f6899af5352d62c970ddc93c84e6

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: ef30637f24e728ec1e8629275ee8bcebe09ed621

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: a6cc2e36fc9aa043c4b8e7e5a9223c95e7bdfd1d

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: e0c7c0e9952fb069e2118ceaa700b80d94d1c267

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: 422bd60a21e050d3681aa8c4e6c04e204e149a1a

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: cffc20e846641adfa8c07720e153c9a7970344b3

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: 2d36edcbe58468e7a33ddf3f7ff5b98df3eb063b

Build ID: 8

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: 6443d998377878b8a3f0a2e982e46b79b9b95785

Build ID: 9

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 4 months ago

Commit ID: a88145a5b432692123dacf2ccf8bba2ec696d0b1

Build ID: 10

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

mfbalin commented 2 months ago

Is it safe to merge this?

pyynb commented 2 months ago

Is it safe to merge this?

yes, I've done the unit test.