Closed mfbalin closed 3 months ago
To trigger regression tests:
@dgl-bot run [instance-type] [which tests] [compare-with-branch]
;
For example: @dgl-bot run g4dn.4xlarge all dmlc/master
or @dgl-bot run c5.9xlarge kernel,api dmlc/master
@mfbalin why do we need to be compatible with gcc 13? and gklib is the only blocker to be compatible with gcc 13?
@mfbalin why do we need to be compatible with gcc 13? and gklib is the only blocker to be compatible with gcc 13?
Old METIS code had a compile error with GCC 13. GKLib shipped inside METIS before but now it is not so we add it as a submodule. Updating the software version should improve the experience.
We don't have to be compatible but GCC 13 ships with Ubuntu 24.04.
It is better to be compatible with this little effort and support latest OS default compiler.
@classicsong Please help review change on GKlib
as it's quite long ago(6 years gap between the one we're using and the latest on master branch) since last change, so I'm not sure if it's safe to change it to latest.
@mfbalin As there's large time gap between the current one we're using and the new one you'd apply, it's risky and requires more reviews from other team member even the author. Let's hold on for now.
Let's aim GS 0.3 release around July 2024, before the release there will be comprehensive test.
@frozenbugs I think GS 0.3 release is out.
@frozenbugs do we or GS run comprehensive test over this PR? As I just disabled the whole distributed tests, please run them manually.
@frozenbugs do we or GS run comprehensive test over this PR? As I just disabled the whole distributed tests, please run them manually.
GS will do it.
As we discussed offline, let's merge it into master and ask GS to help test it thoroughly. @mfbalin As I've just disabled all distributed test in CI, please run them manually before merge it into master branch. Thanks.
I checked the CI and it runs distributed tests. Let's merge it.
Description
Updating METIS to the latest master branch. GKlib was taken out of METIS so adding it manually as a submodule. Adding missing include. The code compiles with GCC 13 (shipped with Ubuntu 24.04) with this PR.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes