dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.
http://dgl.ai
Apache License 2.0
13.41k stars 3k forks source link

[Misc] Make code compilable with GCC 13 #7363

Closed mfbalin closed 3 months ago

mfbalin commented 5 months ago

Description

Updating METIS to the latest master branch. GKlib was taken out of METIS so adding it manually as a submodule. Adding missing include. The code compiles with GCC 13 (shipped with Ubuntu 24.04) with this PR.

Checklist

Please feel free to remove inapplicable items for your PR.

Changes

dgl-bot commented 5 months ago

To trigger regression tests:

dgl-bot commented 5 months ago

Commit ID: 04ac3729ad54dc00a326ceea0e9218cea11faaf3

Build ID: 1

Status: ❌ CI test failed in Stage [CPU Build (Win64)].

Report path: link

Full logs path: link

dgl-bot commented 5 months ago

Commit ID: 04ac3729ad54dc00a326ceea0e9218cea11faaf3

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Rhett-Ying commented 5 months ago

@mfbalin why do we need to be compatible with gcc 13? and gklib is the only blocker to be compatible with gcc 13?

mfbalin commented 5 months ago

@mfbalin why do we need to be compatible with gcc 13? and gklib is the only blocker to be compatible with gcc 13?

Old METIS code had a compile error with GCC 13. GKLib shipped inside METIS before but now it is not so we add it as a submodule. Updating the software version should improve the experience.

We don't have to be compatible but GCC 13 ships with Ubuntu 24.04.

mfbalin commented 5 months ago

It is better to be compatible with this little effort and support latest OS default compiler.

Rhett-Ying commented 5 months ago

@classicsong Please help review change on GKlib as it's quite long ago(6 years gap between the one we're using and the latest on master branch) since last change, so I'm not sure if it's safe to change it to latest.

Rhett-Ying commented 5 months ago

@mfbalin As there's large time gap between the current one we're using and the new one you'd apply, it's risky and requires more reviews from other team member even the author. Let's hold on for now.

dgl-bot commented 5 months ago

Commit ID: 0c85c11659e5f3bb2d488dd179dac17fa4251c7c

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

frozenbugs commented 5 months ago

Let's aim GS 0.3 release around July 2024, before the release there will be comprehensive test.

dgl-bot commented 5 months ago

Commit ID: a15c452ff619393f94c8dc3cd2410e40a629fdfd

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

mfbalin commented 3 months ago

@frozenbugs I think GS 0.3 release is out.

Rhett-Ying commented 3 months ago

@frozenbugs do we or GS run comprehensive test over this PR? As I just disabled the whole distributed tests, please run them manually.

frozenbugs commented 3 months ago

@frozenbugs do we or GS run comprehensive test over this PR? As I just disabled the whole distributed tests, please run them manually.

GS will do it.

Rhett-Ying commented 3 months ago

As we discussed offline, let's merge it into master and ask GS to help test it thoroughly. @mfbalin As I've just disabled all distributed test in CI, please run them manually before merge it into master branch. Thanks.

dgl-bot commented 3 months ago

Commit ID: cf38d4beb9be2bcd3105e5413398877669e44722

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Rhett-Ying commented 3 months ago

I checked the CI and it runs distributed tests. Let's merge it.