dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.
http://dgl.ai
Apache License 2.0
13.41k stars 3k forks source link

[GraphBolt] Remove workaround for `DILL_AVAILABLE` in torch 2.3.0 #7387

Closed Rhett-Ying closed 2 months ago

Rhett-Ying commented 5 months ago

🔨Work Item

IMPORTANT:

Project tracker: https://github.com/orgs/dmlc/projects/2

Description

Depending work items or issues

Rhett-Ying commented 5 months ago

see https://github.com/dmlc/dgl/pull/7383#

mfbalin commented 4 months ago

https://github.com/pytorch/pytorch/issues/125425#issuecomment-2108698508

Looks like the fix will be available in 2.3.1.

mfbalin commented 4 months ago

https://github.com/pytorch/pytorch/issues/124907#issuecomment-2108790596

Rhett-Ying commented 3 months ago

back-compatible is available since torch 2.3.1. we should make change on current workaround in DGL: https://github.com/dmlc/dgl/blob/7c3d418e88fe0a20f56971ec4ca54cd026bdfe0d/python/dgl/graphbolt/base.py#L9-L16

mfbalin commented 2 months ago

Fixed by #7474.