dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.

http://dgl.ai

Apache License 2.0

13.41k stars 3k forks source link

[GraphBolt][DeprecationWarning]Deprecation warning resolved. #7443

Closed drivanov closed 3 months ago

drivanov commented 4 months ago

Description

The following DeprecationWarning is fixed:

  /usr/local/lib/python3.10/dist-packages/dgl/graphbolt/base.py:81: DeprecationWarning: torch.library.impl_abstract 
was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a 
future version of PyTorch.
    @torch.library.impl_abstract("graphbolt::expand_indptr")

Checklist

Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[x] I've leverage the tools to beautify the python and c++ code.
[x] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
[x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

dgl-bot commented 4 months ago

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot commented 4 months ago

Commit ID: 2fff0a35f2aee8a66841f9742fadf5917bffc081

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

mfbalin commented 4 months ago

@dgl-bot

dgl-bot commented 4 months ago

Commit ID: 2fff0a35f2aee8a66841f9742fadf5917bffc081

Build ID: 2

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

mfbalin commented 4 months ago

____ ERROR collecting tests/python/pytorch/dataloading/test_dataloader.py _____
tests\python\pytorch\dataloading\test_dataloader.py:6: in &lt;module&gt;
    import backend as F
tests\backend\__init__.py:8: in &lt;module&gt;
    from dgl.nn import *
python\dgl\__init__.py:16: in &lt;module&gt;
    from . import (
python\dgl\dataloading\__init__.py:13: in &lt;module&gt;
    from .dataloader import *
python\dgl\dataloading\dataloader.py:27: in &lt;module&gt;
    from ..distributed import DistGraph
python\dgl\distributed\__init__.py:5: in &lt;module&gt;
    from .dist_graph import DistGraph, DistGraphServer, edge_split, node_split
python\dgl\distributed\dist_graph.py:11: in &lt;module&gt;
    from .. import backend as F, graphbolt as gb, heterograph_index
python\dgl\graphbolt\__init__.py:39: in &lt;module&gt;
    from .base import *
python\dgl\graphbolt\base.py:81: in &lt;module&gt;
    @torch.library.register_fake("graphbolt::expand_indptr")
E   AttributeError: module 'torch.library' has no attribute 'register_fake'

mfbalin commented 3 months ago

7493 has the fix that continues to work with older pytorch.