[Feature] Add check for `NNZ` in `COOToCSR`

dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.

http://dgl.ai

Apache License 2.0

13.18k stars 2.99k forks source link

[Feature] Add check for `NNZ` in `COOToCSR` #7459

Closed Skeleton003 closed 2 weeks ago

Skeleton003 commented 3 weeks ago

Description

Add check for the number of non-zero elements (NNZ) during the conversion from COOMatrix to CSRMatrix within the spmat_op_impl_coo.cc file.

Checklist

Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[ ] I've leverage the tools to beautify the python and c++ code.
[ ] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
[ ] All changes have test coverage
[ ] Code is well-documented
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR
[ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

dgl-bot commented 3 weeks ago

To trigger regression tests:

@dgl-bot run [instance-type] [which tests] [compare-with-branch]; For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

dgl-bot commented 3 weeks ago

Commit ID: 57b1572c3c49be51635fcea7bf403516b1da932e

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

Skeleton003 commented 3 weeks ago

pls add dedicated testcase

I'm afraid it's a little bit difficult because we need to construct a COO with more than 2B NNZ for a testcase.

dgl-bot commented 3 weeks ago

Commit ID: 73dc41336ee6b88e5db17b6a0651e5e55fb10f31

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 3 weeks ago

Commit ID: 716acae329f74e95ba2294d36bcb8e123fde0c3c

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 3 weeks ago

Commit ID: afaa2abccb45010ec2f166a87b06f773ee06c1c0

Build ID: 4

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot commented 3 weeks ago

Commit ID: 86f8846ab0b4c5f54ae8732d8a39e331079ca596

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 3 weeks ago

Commit ID: 86f8846ab0b4c5f54ae8732d8a39e331079ca596

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 3 weeks ago

Commit ID: e3b1fad64c3d4151268fb6eeddfe69fd2866619d

Build ID: 7

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

Rhett-Ying commented 2 weeks ago

The CI failed due to glitch in distributed testcases. It's ok to ignore such failures.

dgl-bot commented 2 weeks ago

Commit ID: 382eda5747196694157684f9d178632748c7527c

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link