[Misc] Fix spurious test failure.

mfbalin commented 2 months ago

Description

We run the test for a maximum of 10 times to see if it will ever succeed 80% over time. If it succeeds on 1st try, then no extra iteration will be performed. If it fails on 1st try, then it will need to succeed on the following 4 tries to count as test pass. If it fails 3 times, then it will count as failure as %80 success is not possible anymore.

Fixes https://github.com/dmlc/dgl/pull/7506#issuecomment-2216813220

Checklist

Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[ ] I've leverage the tools to beautify the python and c++ code.
[ ] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
[ ] All changes have test coverage
[ ] Code is well-documented
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR
[ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

dgl-bot commented 2 months ago

To trigger regression tests:

@dgl-bot run [instance-type] [which tests] [compare-with-branch]; For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

dgl-bot commented 2 months ago

Commit ID: ec1d0e3f4ea6ef43ca6498df8270dcb7649ac47d

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: 6dde44f4e58c83af55899e8e4f57ecd701accc21

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

mfbalin commented 2 months ago

@frozenbugs @Rhett-Ying Is there a way to make this probabilistic logic into a test decorator for the flaky tests? I am not a Python expert.

dgl-bot commented 2 months ago

Commit ID: 1d428190efe958b446a2131075fde4dc0c26d0ec

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

frozenbugs commented 2 months ago

I'd rather to lower it to 0.6. We will move this to regression framework and remove this.

dgl-bot commented 2 months ago

Commit ID: a999f81548cae77a2e552c892354700a8344e064

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

mfbalin commented 2 months ago

@frozenbugs I refactored the logic into a function. If more tests fail in the future before these tests are removed, we can simply reuse the wrapper to make them more robust.

dgl-bot commented 2 months ago

Commit ID: a999f81548cae77a2e552c892354700a8344e064

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: 624d7cd0c5cb571af8c7d95f853daf99aed9c412

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dmlc / dgl