dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.
http://dgl.ai
Apache License 2.0
13.53k stars 3.02k forks source link

[GraphBolt][io_uring] Improve detection and simplify code. #7515

Closed mfbalin closed 3 months ago

mfbalin commented 3 months ago

Description

Eliminate redundant check and unnecessary nested if. Improve detection by checking if underlying system supports file read requests via io_uring. This is to fix test failure on machines with old kernel versions.

TODO for later: Overlap disk reads with memcpy operations after reads are done by submitting 2 times groupsize operations into the submission queue. After the second submission, wait for the first set of submissions.

TODO for later: Consider using readv so that we don't need memcpy.

@chang-l tested the code (big thanks!), our detection logic works for old kernel versions that have io uring but does not support the file read operations.

Checklist

Please feel free to remove inapplicable items for your PR.

Changes

dgl-bot commented 3 months ago

To trigger regression tests:

dgl-bot commented 3 months ago

Commit ID: 85bfcf8cda26fcaf7240d9b8f4e034d1a6333cc9

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 3 months ago

Commit ID: 0db100c5ff01a2a3b6dfa86dd4f2a15d0a19f63a

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 3 months ago

Commit ID: 2c652e27c376dd667c8edc77642215e9cd9db834

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 3 months ago

Commit ID: daa2c1e35d35a1e61bc7a94a41a28f28609345dc

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 3 months ago

Commit ID: 4f09f2e28f92095310a7933f9bca48fcf54771b9

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link