[CI] Add a new environment called pytorch-min-ci

mfbalin commented 2 months ago

Description

We support torch 2.1.0 as our minimum. The latest torch version we support is 2.3.1. The least we can do is to run tests for both versions in the CI to be more robust. @Rhett-Ying could you help achieve that? This PR is simply building our container to include 2 environments for pytorch, pytorch-ci for the latest torch we support and pytorch-min-ci for the oldest torch we support. Feel free to push to this branch if it is not mergeable like this, I opened this PR to kickstart the effort and help you.

Motivation: prevent mistakes like #7521 from occurring again.

I think it would be best if we modified the CI related files so that we can easily run the tests for any number of torch versions. The ideal case is to test all the pytorch versions that we claim to support in the CI.

Checklist

Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[ ] I've leverage the tools to beautify the python and c++ code.
[ ] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
[ ] All changes have test coverage
[ ] Code is well-documented
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR
[ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

dgl-bot commented 2 months ago

To trigger regression tests:

@dgl-bot run [instance-type] [which tests] [compare-with-branch]; For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

mfbalin commented 2 months ago

@frozenbugs FYI.

dgl-bot commented 2 months ago

Commit ID: 27b1ba6cdef911a727cbe891ddfc115d2efef45b

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Rhett-Ying commented 2 months ago

Covering different version combination of torch, cuda is not necessary for CI. CI is just cover the basic unit tests. Instead, our regression or release pipeline should cover (Unfortunately it's not covered yet).

mfbalin commented 2 months ago

Covering different version combination of torch, cuda is not necessary for CI. CI is just cover the basic unit tests. Instead, our regression or release pipeline should cover (Unfortunately it's not covered yet).

Then shall we remove the newly added pytorch version related things and merge the refactored remaining portion? There was quite a lot of duplication in some files. Maybe you want to personally test before merging so it is okay to keep this PR open until we can actually test it.

dmlc / dgl